masahi commented on issue #4418: [RUNTIME] Add cudnn conv3d
URL: https://github.com/apache/incubator-tvm/pull/4418#issuecomment-559456916
 
 
   conv_output_shape, conv_find_algo, and conv_forward look good. Once we have 
them, we don't need conv2d_output_shape, conv3d_output_shape etc that just 
forward to corresponding generic function are not necessary. Please remove 
everything in 
[here](https://github.com/optima2005/incubator-tvm/blob/test/python/tvm/contrib/cudnn.py#L383-L759).
 
   
   You can use conv_output_shape, conv_find_algo, and conv_forward from tests 
and topi. Can you update this PR according to this comment?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to