tqchen commented on a change in pull request #4455: Fix MSVC build error with
container.h
URL: https://github.com/apache/incubator-tvm/pull/4455#discussion_r352968146
##########
File path: include/tvm/runtime/container.h
##########
@@ -198,6 +198,7 @@ class ADTObj : public Object, public
InplaceArrayBase<ADTObj, ObjectRef> {
}
friend class ADT;
+ template <typename ArrayType, typename ElemType>
Review comment:
consider change to InplaceArrayBase<ADTObj, ObjectRef>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
