apivovarov commented on a change in pull request #4484: [FRONTEND][TF] 
conv2d_transpose 'SAME' support kernel more than 1x1
URL: https://github.com/apache/incubator-tvm/pull/4484#discussion_r355686140
 
 

 ##########
 File path: src/relay/op/nn/convolution.cc
 ##########
 @@ -248,10 +248,17 @@ bool Conv2DTransposeRel(const Array<Type>& types,
   }
   // dilation
   Array<IndexExpr> oshape({dshape_nchw[0], channels, 0, 0});
-  oshape.Set(2, (param->strides[0] * (dshape_nchw[2] - 1) + dilated_ksize_y -
-                 2 * param->padding[0] + param->output_padding[0]));
-  oshape.Set(3, (param->strides[1] * (dshape_nchw[3] - 1) + dilated_ksize_x -
-                 2 * param->padding[1] + param->output_padding[1]));
+  if ( param->padding.size() == 2 ) {
 
 Review comment:
   minor formatting comment. I think we do not need spaces after `(` and before 
`)`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to