liangfu commented on a change in pull request #4482: [Relay] External codegen
URL: https://github.com/apache/incubator-tvm/pull/4482#discussion_r355927062
##########
File path: include/tvm/build_module.h
##########
@@ -170,6 +170,9 @@ TVM_DLL Target intel_graphics(const
std::vector<std::string>& options =
TVM_DLL Target stackvm(const std::vector<std::string>& options =
std::vector<std::string>());
+/*! \return A target for ext_dev */
+TVM_DLL Target ext_dev(const std::vector<std::string>& options =
Review comment:
Shall we avoid using the name `ext_dev` for a target, since there is a
`ext_dev` for TVMContext? See
https://github.com/apache/incubator-tvm/blob/97e333cac8313075e7f7067d2d078782e793e0cc/python/tvm/ndarray.py#L171
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
