FrozenGene commented on issue #4511: [CONV] Asymmetric padding URL: https://github.com/apache/incubator-tvm/pull/4511#issuecomment-564893702 For `topi/python/topi/x86/conv2d_alter_op.py`, do you mean `legalize`? We should modify it. Because the get_int_tuple["padding"] maybe return 4D padding. Then next we should use pad_top, pad_bottom to represent (pad_h, pad_h) , pad_left, pad_right to represent (pad_w, pad_w). i.e. padding[0] and padding[1] there. For `topi/python/topi/rocm/conv2d.py`, I think we could get `pad_h` / `pad_w` use `pad_top + pad_bottom` / `pad_left + pad_right`, then pass to `miopen.conv2d_forward`. This is the same as `cudnn`. We don't change the interface of cudnn, but change the value passed to them. For `topi/include/topi/nn.h` , conv2d_* / depthwise_conv2d_* shouldn't be used in any other places, because we use Python's topi version of conv2d / depthwise_conv2d, so we could keep them.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
