zhiics commented on issue #4482: [Relay] External codegen URL: https://github.com/apache/incubator-tvm/pull/4482#issuecomment-566184570 @tqchen how about this? > The keyword IsExternal is still quite confusing. I would suggest make the attribute "compiler", alternatively we can call it a "backend". When it is set, we will look up for the customized compiler hook. The value "default" invokes the default compilation pipeline. > Let us deliberate a bit on the FuncName keyword. While I understand it is necessary to attach such attribute before lowering to that ensure consistent symbol lookup, is it the right name? Change "external" to "compiler". The value is compiler+id, e.g. "dnnl_1" and "dnnl_2" so that we can have a unique name for symbol lookup. And then we can just remove the "FuncName" attribute. Or do you have other suggestions? > More broadly, as we start to introduce more attributes to functions, it would be great to come up We have moved them to `relay::attrs` and documented.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
