kevinthesun commented on a change in pull request #4518: [Bugfix][Frontend][TF]
Fix incorrect calculations in tf SLICE
URL: https://github.com/apache/incubator-tvm/pull/4518#discussion_r358601463
##########
File path: python/tvm/relay/frontend/tensorflow.py
##########
@@ -639,7 +639,7 @@ def _impl(inputs, attr, params):
end = size
for i in range(data_dim):
if size[i] == -1:
- end[i] = data_shape[i] - begin[i]
+ end[i] = data_shape[i] - begin[i] + 1
Review comment:
In tf doc, when size=-1. it means all remaining elements should be included.
So here should be end[i] = data_shape[i]?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
