tqchen commented on a change in pull request #4532: [WIP] Support standardize
runtime module
URL: https://github.com/apache/incubator-tvm/pull/4532#discussion_r359058982
##########
File path: python/tvm/module.py
##########
@@ -118,21 +122,22 @@ def export_library(self,
self.save(file_name)
return
- if not (self.type_key == "llvm" or self.type_key == "c"):
- raise ValueError("Module[%s]: Only llvm and c support export
shared" % self.type_key)
+ module = self._lookup_dso_module()
+ assert module is not None, "We should have one dso module to export"
Review comment:
Is it a hard requirement? things should also works fine if all modules are
non dso?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
