tqchen opened a new pull request #4606: [REFACTOR] Unify approach to 
Visitor/Mutator under Functor
URL: https://github.com/apache/incubator-tvm/pull/4606
 
 
   IRMutator and IRVisitor were the main data structures for doing low level IR 
visiting.
   As the project evolves, we start to introduce more powerful variants such as 
StmtFunctor and ExprFunctor.
   This PR brings new classes that allows us to migrate the visitor mutator to 
be sub-class of these functors.
   
   List of changes:
   
   - Create separate class for ExprMutator and StmtMutator, following 
convention used in relay.
   - Introduce copy-on-write to StmtMutator that can later benefit the 
statement mutations
     if we use move semantics and keep a single copy of stmt.
   - Move two generic visit mutate util to use the new classes.
   
   We will send followup PRs to migrate the existing passes that use the legacy 
visitors
   to the new one.
   
   Thanks for contributing to TVM!   Please refer to guideline 
https://docs.tvm.ai/contribute/ for useful information and tips. After the pull 
request is submitted, please request code reviews from 
[Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers)
 by @ them in the pull request thread.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to