wweic commented on a change in pull request #4643: [REFACTOR] Replace TensorObj
and TensorValue with NDArray
URL: https://github.com/apache/incubator-tvm/pull/4643#discussion_r364077343
##########
File path: include/tvm/relay/interpreter.h
##########
@@ -111,22 +89,22 @@ class ClosureNode : public ValueNode {
v->Visit("func", &func);
}
- TVM_DLL static Closure make(tvm::Map<Var, Value> env, Function func);
+ TVM_DLL static Closure make(tvm::Map<Var, ObjectRef> env, Function func);
static constexpr const char* _type_key = "relay.Closure";
- TVM_DECLARE_FINAL_OBJECT_INFO(ClosureNode, ValueNode);
+ TVM_DECLARE_FINAL_OBJECT_INFO(ClosureNode, Object);
};
-class Closure : public Value {
+class Closure : public ObjectRef {
public:
- TVM_DEFINE_OBJECT_REF_METHODS(Closure, Value, ClosureNode);
+ TVM_DEFINE_OBJECT_REF_METHODS(Closure, ObjectRef, ClosureNode);
};
/*! \brief A Relay Recursive Closure. A closure that has a name. */
class RecClosure;
/*! \brief The container type of RecClosure. */
-class RecClosureNode : public ValueNode {
+class RecClosureNode : public Object {
Review comment:
```suggestion
class RecClosureObj : public Object {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
