zhiics commented on a change in pull request #4657: [CodeGen] Generate blob use
LLVM directly
URL: https://github.com/apache/incubator-tvm/pull/4657#discussion_r364360657
##########
File path: include/tvm/build_module.h
##########
@@ -109,6 +109,23 @@ class Target : public ObjectRef {
*/
TVM_DLL static tvm::Target Current(bool allow_not_defined = true);
+ /*!
+ * \brief Get the target host based on LLVM.
+ * \return The target host based on LLVM.
+ */
Review comment:
I am not sure, but it looks a little wired to me to have these in `Target`.
Shouldn't we just use `Target::llvm()` directly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
