FrozenGene edited a comment on issue #4657: [CodeGen] Generate blob use LLVM directly URL: https://github.com/apache/incubator-tvm/pull/4657#issuecomment-572222539 > If we indeed needs to pass target triple, perhaps the best way to do so is to pass that as an argument of PackImportToLLVM @tqchen So, your opinion is let the users specify. The API will become this: ``` def export_library(self, file_name, fcompile=None, llvm_target=None, **kwargs): if enabled("llvm"): path_obj = temp.relpath("devc.o") m = _PackImportsToLLVM(self, is_system_lib, llvm_target) ``` If users doesn't set `llvm_target`, we use the default value. (system target triple). if users want to compile into another os / another cpu, they have to do this: ```module.export_library(..., llvm_target="llvm -target aarch64-linux-gnu-none")``` now. Does it make sense to you?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
