tqchen commented on a change in pull request #4657: [CodeGen] Generate blob use
LLVM directly
URL: https://github.com/apache/incubator-tvm/pull/4657#discussion_r364914242
##########
File path: src/codegen/llvm/llvm_module.cc
##########
@@ -62,6 +63,11 @@ class LLVMModuleNode final : public runtime::ModuleNode {
return PackedFunc([flag](TVMArgs args, TVMRetValue *rv) {
* rv = flag;
});
+ } else if (name == "get_target_triple") {
Review comment:
consider rename to _get_target_triple just to avoid potential user defined
function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
