tqchen commented on a change in pull request #4657: [CodeGen] Generate blob use
LLVM directly
URL: https://github.com/apache/incubator-tvm/pull/4657#discussion_r365069930
##########
File path: python/tvm/contrib/cc.py
##########
@@ -51,9 +51,32 @@ def create_shared(output,
else:
raise ValueError("Unsupported platform")
+def get_target_triple():
+ """ Get the target triple using compiler.
+
+ Returns
+ -------
+ out: str (Linux / Mac) or None (Win32)
+ """
+ if sys.platform == "darwin" or sys.platform.startswith("linux"):
+ cmd = ["g++", "-dumpmachine"]
+ proc = subprocess.Popen(
+ cmd, stdout=subprocess.PIPE, stderr=subprocess.STDOUT)
+ (out, _) = proc.communicate()
+ if proc.returncode != 0:
+ msg = "dumpmachine error:\n"
+ msg += py_str(out)
+ raise RuntimeError(msg)
+ return py_str(out)
+ elif sys.platform == "win32":
+ return None
+ else:
+ raise ValueError("Unsupported platform")
+
# assign so as default output format
create_shared.output_format = "so" if sys.platform != "win32" else "dll"
+create_shared.get_target_triple = get_target_triple()
Review comment:
In the case of _fcompile, we can simply assign it to get_target_triple if
user pass it in, or assign it to None
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
