tqchen commented on a change in pull request #4684: [Arith] add ShapeVar
representing non-neg valued variable in a tensor shape
URL: https://github.com/apache/incubator-tvm/pull/4684#discussion_r365612326
##########
File path: src/arithmetic/int_set.cc
##########
@@ -529,6 +554,22 @@ class IntervalSetEvaluator :
return Combine<T>(analyzer_, a, b);
}
+ template<typename T>
+ inline IntervalSet VisitDivExpr_(const T* op) {
+ IntervalSet a = this->Eval(op->a);
+ IntervalSet b = this->Eval(op->b);
+ if ((MatchPoint(a, op->a) && (MatchPoint(b, op->b) || SelfBoundedVar(b,
op->b)))
+ || (SelfBoundedVar(a, op->a) && SelfBoundedVar(b, op->b))) {
+ // e.g.,
Review comment:
This part is a bit confusing. If the divisor is already a set(which means it
is relaxed), we should not return the original var.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
