tqchen commented on a change in pull request #4684: [Arith] add ShapeVar
representing non-neg valued variable in a tensor shape
URL: https://github.com/apache/incubator-tvm/pull/4684#discussion_r365928076
##########
File path: src/arithmetic/bound_deducer.cc
##########
@@ -297,6 +331,18 @@ void BoundDeducer::Transform() {
void BoundDeducer::Deduce() {
Init();
if (!success_) return;
+
+ // Any variable appears in both expr and result,
Review comment:
I see, perhaps we can add more explanation then.
Also, would it results in an incorrect bound? or just a more strict
bound(which still makes the condition holds)
For a better approach. My feeling is that we should first have a rewriting
that tries to move vars into one side
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
