icemelon9 edited a comment on issue #4318: [Relay][TOPI]Fix meaning of 
conv2d_transpose output_padding parameter
   @abergeron @vinx13 @tmoreau89 
   I found out two problems in this PR. 
   1. In this 
 `h+dh` can be potentially out of boundary. `max(h) = out_h - 1 = in_h - 
filter_h + output_padding[0]` and `max(dh) = filter_h - 1`, therefore, 
`max(h+dh) = in_h + output_padding[0] - 1`. When `output_padding[0] >= 1`, 
`max(h+dh) >= in_h`, which is out of `data_pad` height boundary. Similar to 
   2. The x86 conv2d_transpose implementation is different from generic 
conv2d_tranpose. In x86, after you call `conv2d_transpose_nchw_preprocess`, you 
directly call the normal conv2d without using `output_padding`.
   I'll revert this PR for now. Could you fix these two bugs and double check 
whether cuda and arm_cpu implementation are correct? Further, could you 
investigate why CI doesn't catch these errors?

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

Reply via email to