liangfu commented on a change in pull request #4703: [VTA] Support network 
which have no unique operator as start/stop name for graph pack.
URL: https://github.com/apache/incubator-tvm/pull/4703#discussion_r366724818
 
 

 ##########
 File path: vta/python/vta/top/graphpack.py
 ##########
 @@ -246,32 +246,42 @@ def visit_call(self, call):
 
 class BT(Exception):
     pass
-def get_subgraph(expr, start_name, stop_name):
+def get_subgraph(expr, start_name, stop_name, start_name_indx=0, 
stop_name_indx=0):
     """ We assume stop_name only appears once for simplicity.
         This constraint will be lifted in the future.
         bitpack_start and bitpack_end are both inclusive.
     """
     bitpack_start = op.op.get('annotation.bitpack_start')
     bitpack_end = op.op.get('annotation.bitpack_end')
     anf = run_opt_pass(expr, transform.ToANormalForm())
-    def _recursion(anf, start_found, stop_found):
+    start_name_num = 0
+    stop_name_num = 0
+    def _recursion(anf, start_found, stop_found, start_name_num, 
stop_name_num):
 
 Review comment:
   CHECK: when start_name==stopname, start index should be smaller than stop 
index.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to