FrozenGene commented on a change in pull request #4695:
[Relay][Frontend][TFlite] Add parser support for relational ops
URL: https://github.com/apache/incubator-tvm/pull/4695#discussion_r368262724
##########
File path: python/tvm/relay/frontend/tflite.py
##########
@@ -616,6 +621,36 @@ def convert_greater(self, op):
'TFlite quantized greater operator is not supported yet.')
return self._convert_elemwise(_op.greater, op)
+ def convert_greater_equal(self, op):
+ if self.is_quantized(op):
+ raise tvm.error.OpNotImplemented(
+ 'TFlite quantized GREATER_EQUAL operator is not supported
yet.')
Review comment:
Seems that we have two styles of it. Some code use `lowercase` like
`convert_greater`, some code use `uppercase` like `convert_neg`. I think we
should unify them to `uppercase`. Two reasons: 1. it corresponds to our
`convert_map` / tflite operator string represenation. 2. it could make us catch
the operator more quickly in one sentence like @inadob said. So @inadob could
you help to update other code to `uppercase` too? Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
