Hzfengsy commented on a change in pull request #4765: [tir] make IterVar
extends Var
URL: https://github.com/apache/incubator-tvm/pull/4765#discussion_r369340510
##########
File path: src/tir/ir/expr.cc
##########
@@ -45,24 +45,28 @@ SizeVar::SizeVar(std::string name_hint, DataType t)
SizeVarNode::SizeVarNode(DataType t, std::string name_hint)
: VarNode(t, std::move(name_hint)) {}
-IterVar IterVarNode::make(Range dom,
- Var var,
- IterVarType t,
- std::string thread_tag) {
- ObjectPtr<IterVarNode> n = make_object<IterVarNode>();
- n->dom = dom;
- n->var = var;
- n->iter_type = t;
- n->thread_tag = thread_tag;
- return IterVar(n);
+IterVarNode::IterVarNode(DataType dtype, std::string name_hint,
Review comment:
I'm not sure whether we need a constructor for Node
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
