masahi commented on issue #4497: [WIP] [Relay] Add a PyTorch to Relay Parser URL: https://github.com/apache/incubator-tvm/pull/4497#issuecomment-579038361 @alexwong I'm 100% for "make all of the simpler changes to get this merged first". I don't want you to spend your time redoing the refactoring work I did. Of course, if you want to improve your PR and have time to do so, go ahead and do that as you like. In particular, good simplification can be done around GetAttr node parsing logic and inputs/outputs handling inside main loop (my gist above have my take on this). Anyway, the must TODOs for this PR before we merge are, * Make CI green * Make it work with PyTorch 1.4 (just add `torch._C._jit_pass_inline(graph)`) * Replace all the string hacks with PyTorch's Python interface for JIT data structures After we merge this PR, I'll send a refactoring PR (only about 200 lines change, all op conversion and test cases will be used as is). I've finished refactoring on my branch and currently working on quantized model support. I'm also looking at dynamic models with control flow nodes.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
