GuoliangLiCN opened a new issue #4831: [Relay][FrontEnd][MxNet] incorrect 
data_min_idx and data_max_idx in _qnn_conv
URL: https://github.com/apache/incubator-tvm/issues/4831
 
 
   In the lines 1409-1413 of file python/tvm/relay/frontend/mxnet.py, are there 
typos when has_sum is False?
   >             data_min_idx = -1
   >             data_max_idx = -2
   >             if has_sum:
   >                 data_min_idx = -4
   >                 data_max_idx = -3
   
   Should data_min_idx be -2 and data_max_idx be -1 according to lines 467-474 
of 
https://github.com/apache/incubator-mxnet/blob/master/src/operator/subgraph/mkldnn/mkldnn_conv.cc
   
   >   if (param.full_conv_param.mkldnn_param.quantized) {
   >     input_names.emplace_back("data_min");
   >     input_names.emplace_back("data_max");
   >     if (param.full_conv_param.mkldnn_param.with_sum) {
   >       input_names.emplace_back("sum_min");
   >       input_names.emplace_back("sum_max");
   >     }
   >   }
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to