wweic commented on a change in pull request #4628: [Object] Add String container URL: https://github.com/apache/incubator-tvm/pull/4628#discussion_r376758283
########## File path: include/tvm/runtime/container.h ########## @@ -24,6 +24,19 @@ #ifndef TVM_RUNTIME_CONTAINER_H_ #define TVM_RUNTIME_CONTAINER_H_ +#if defined(__cpp_lib_experimental_string_view) && \ + __cpp_lib_experimental_string_view >= 201411 +#define TVM_USE_CXX14_STRING_VIEW +#elif defined(__cpp_lib_string_view) && __cpp_lib_string_view >= 201606 +#define TVM_USE_CXX17_STRING_VIEW Review comment: Good point! I have improved it to ensure both macros are defined. The old way will cause build warning `Macro expansion producing 'defined' has undefined behavior`, ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
