FrozenGene commented on issue #4748: [RELAY] Support RelayBuild with Only Constants URL: https://github.com/apache/incubator-tvm/issues/4748#issuecomment-583851947 >I even think it is just okay to leave it as it is because it means we just return a null pointer when returning an empty module, which is a valid return. Considering mod is is essentially a shared pointer, the failure/crash in dereferencing a null pointer sounds good to me. IMO, I agree with @zhiics 's point here. >There is one more question though: what the target of the dummy function should be? I currently set it to llvm. Should be `target_host_`. `llvm` just means x86 cpu.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
