tqchen commented on a change in pull request #4855: [Refactor] move vm.py under runtime and adt to runtime.container.py URL: https://github.com/apache/incubator-tvm/pull/4855#discussion_r377780629
########## File path: python/tvm/runtime/vm.py ########## @@ -0,0 +1,357 @@ +# License .to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# pylint: disable=no-else-return, unidiomatic-typecheck, undefined-variable, invalid-name, redefined-builtin +""" +The Relay Virtual Machine runtime. + +Implements a Python interface to executing the compiled VM object. +""" +import numpy as np + +import tvm +from tvm._ffi.runtime_ctypes import TVMByteArray +from tvm._ffi import base as _base +from .object import Object +from . import _ffi_api, container + +def _convert(arg, cargs): + if isinstance(arg, Object): + cargs.append(arg) + elif isinstance(arg, np.ndarray): + nd_arr = tvm.nd.array(arg, ctx=tvm.cpu(0)) + cargs.append(nd_arr) + elif isinstance(arg, tvm.nd.NDArray): Review comment: nd array is under runtime, consider change to tvm.runtime.NDArray here(because nd is an alias for outside) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
