kumasento commented on issue #4847: Use dummy func when no lowered_funcs exists in Relay mod URL: https://github.com/apache/incubator-tvm/pull/4847#issuecomment-584869309 Thank you guys for all your kind reviews! @mbarrett97 @FrozenGene @tqchen @zhiics I've updated this PR to fulfill the following revisions: 1. Using `CSourceModule` with an empty string as the returned module object `ret_.mod`, instead of creating a dummy lowered function. 2. Removed the warning based on @mbarrett97 review. Now the generated module looks clean and tidy. No redundant dummy function generated and no extra design decisions should be made. Please let me know if there is anything else you feel should be done. Thanks!
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
