tqchen edited a comment on issue #4864: [Relay] Ignore Primitive functions in Visitors URL: https://github.com/apache/incubator-tvm/pull/4864#issuecomment-584897668 Given the current discussion, I still think it is better to close this PR for now and take the lift to global approach. While the current solution certainly resolves some of the problem in the short term, it introduces a reverse dependency of the function convention itself. Users of the API may not be aware of such subtle details in the base-class. In the long run, such kind of changes can become a technical debt in the project. Having a specialized sub-class visitor might be better for limited passes that need this behavior. Given that we have an alternative path(lift to global) is certainly cleaner, and will likely become the ultimate solution, let us push for that direction instead :)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
