masahi commented on issue #4874: [QNN] More doc fix on quantize and convolution URL: https://github.com/apache/incubator-tvm/pull/4874#issuecomment-586020980 @anijain2305 do you think it also makes sense to make `units` param in qnn dense required? https://github.com/apache/incubator-tvm/blob/9963cf38689c1c246d1b087af27d679f09afdfa7/python/tvm/relay/qnn/op/qnn.py#L374 This is required if we want to remove the restriction of weight shape being scalar and type check vector weight shape. We want to replace this https://github.com/apache/incubator-tvm/blob/8152360466b57a5c848d3cf05efd373a1690b335/src/relay/qnn/op/dense.cc#L58 with ```cpp AssignType(types[5], DataType::Float(32), param->units, reporter); ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
