mbrookhart commented on a change in pull request #4886: [WIP][POC]First pass a
defining at non-recursive Graph Vistor and Rewriter
URL: https://github.com/apache/incubator-tvm/pull/4886#discussion_r379618563
##########
File path: include/tvm/relay/expr_functor.h
##########
@@ -197,7 +198,7 @@ class ExprMutator
* \brief Mutate is alias for VisitExpr
* \return expr.
*/
- Expr Mutate(const Expr& expr) {
+ virtual Expr Mutate(const Expr& expr) {
Review comment:
Mmm, the way it's current written I need a way to distinguish when I'm
actually visiting and when I'm just querying for the updated child. I'm using
VisitExpr to actually process a node and Mutate to query for the child. I'll
think about a cleaner way to do that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
