soiferj edited a comment on issue #4879: [Relay][Pass] Fix bug in re-processing 
call node in MergeComposite pass
URL: https://github.com/apache/incubator-tvm/pull/4879#issuecomment-586521847
 
 
   Actually, are you sure the second argument is expected? It looks like 
AlphaEqual loops through the LHS args. This has some weird implications, when I 
run the other tests and flip the order of `result` and `expected` in 
alpha_equal, they fail.
   
   Maybe this is because the "expected" doesn't have the composite and 
primitive attributes?
   
   Update: that's the part that's returning false. I think "expected" should be 
arg one, and we need to set the attributes on the function.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to