soiferj edited a comment on issue #4879: [Relay][Pass] Fix bug in re-processing 
call node in MergeComposite pass
URL: https://github.com/apache/incubator-tvm/pull/4879#issuecomment-586529239
 
 
   This test (test_branch_merge) is now failing at the de-duplicate pass. It's 
interesting since the "correct" (result) graph has the exact same function 
duplicated twice. Whereas the "expected" graph is just re-using the same 
function. What should be the correct behavior?
   
   Update: I am still having some trouble with this test. I will look next 
week. I am wondering if we should check this fix in and update the tests 
wholesale in another PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to