Hzfengsy commented on a change in pull request #4885: Split node min range is 
not stringent.
URL: https://github.com/apache/incubator-tvm/pull/4885#discussion_r379769004
 
 

 ##########
 File path: src/te/schedule/message_passing.cc
 ##########
 @@ -62,6 +62,13 @@ void PassDownDomain(const Stage& stage,
     return actx->Simplify(indexdiv(a + (b - 1), b));
   };
 
+  auto minimum = [actx](PrimExpr a, PrimExpr b) {
 
 Review comment:
   The name `minimum` is not exact. This function will only return the minimum 
Expr when the two Expr can be compared. Otherwise, it will return the latter 
one. Maybe we can change to `min_or_later` or any other name whose meaning is 
exact.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to