jmorrill edited a comment on issue #4857: Windows Support for cpp_rpc URL: https://github.com/apache/incubator-tvm/pull/4857#issuecomment-586662854 @FrozenGene Thanks for taking a peek. I totally understand limited time. You are right, I do not include a case for Android to skip linking with pthread. My only excuse was can't really find a solid answer to this in CMake. "if(ANDROID)" would be nice if that's how it is done. I'll be very happy to implement any suggestion though! I made this "first class" option from the main CMake because a) Its a much better implementation on Windows than the python version, which took a bunch of hacks to make decent performance. b) Was very easy to link to the tvm libs given its a sub CMake project.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
