lfengad commented on issue #4882: [Relay][Topi] Hashtable support URL: https://github.com/apache/incubator-tvm/pull/4882#issuecomment-586703234 Dear Tianqi, Thank you so much for the reply and suggestions. I will discuss with my collaborators and propose the RFC thread then. Thank you! Best regards, Liang ________________________________ From: Tianqi Chen <notificati...@github.com> Sent: Saturday, February 15, 2020 12:19 AM To: apache/incubator-tvm <incubator-...@noreply.github.com> Cc: Liang FENG <lfen...@connect.ust.hk>; Mention <ment...@noreply.github.com> Subject: Re: [apache/incubator-tvm] [Relay][Topi] Hashtable support (#4882) Thanks @lfengad<https://github.com/lfengad> for the PR. Given this PR involves a major technical decisions(introducing hashtable to the runtime), can you please open discuss RFC thread in the discuss forum first to discuss possible technical choices? In this way we can converge to the best design that fits our goals By quickly looking at the PR, I can see a few places that can be improve(which we can discuss in depth in the RFC). In particular, we don't have to introduce additional C APIs to the FFI, and should consolidate everything to use the Object instead. While relay's VM runtime already supports Object, it would be interesting to ask whether we want to extend some level of support to the graph RT — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://github.com/apache/incubator-tvm/pull/4882?email_source=notifications&email_token=ADFIA7BQADJRSYEMRWPGHXDRC3ABXA5CNFSM4KVGRWJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELZSF5Y#issuecomment-586359543>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADFIA7C7NOKKXWLQFYOGWI3RC3ABXANCNFSM4KVGRWJQ>.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
