comaniac commented on a change in pull request #4644: [Relay][AutoTVM] Relay op
strategy
URL: https://github.com/apache/incubator-tvm/pull/4644#discussion_r380382775
##########
File path: python/tvm/autotvm/task/relay_integration.py
##########
@@ -67,27 +65,22 @@ def extract_from_program(mod, params, ops, target,
target_host=None,
The module or function to tune
params: dict of str to numpy array
The associated parameters of the program
- ops: List of relay op
- List of relay ops to be tuned
target: tvm.target.Target
The compilation target
target_host: tvm.target.Target
The host compilation target
- template_keys: dict of topi op to str
- The tuning template keys map for schedules, default to None.
- Example: {topi.nn.conv2d: 'direct'}
+ ops: List of relay.op.Op
+ List of relay ops to be tuned
Returns
-------
task: Array of autotvm.task.Task
collected tasks
"""
- return extract_from_multiple_program([mod], [params], ops, target,
target_host,
- template_keys)
+ return extract_from_multiple_program([mod], [params], target, target_host,
ops)
-def extract_from_multiple_program(mods, params, ops, target, target_host=None,
- template_keys=None):
+def extract_from_multiple_program(mods, params, target, target_host=None,
ops=None):
Review comment:
Would that be better if we include all ops by default if `ops=None`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
