tqchen commented on a change in pull request #4891: [TEST][FLAKY]
topi/tests/python/test_topi_sort.py::test_argsort
URL: https://github.com/apache/incubator-tvm/pull/4891#discussion_r382175677
##########
File path: topi/tests/python/test_topi_sort.py
##########
@@ -27,6 +27,12 @@ def verify_argsort(axis, is_ascend):
data_dtype = "float32"
data = tvm.placeholder(dshape, name="data", dtype=data_dtype)
np_data = np.random.uniform(size=dshape).astype(data_dtype)
Review comment:
Ah, sorry I was a bit confused here. The shuffling here still does not
address the problem of ties(two values too close to each other in
random.uniform).
We should instead change this line to directly create arange then broadcast
to the shape, then we shuffle each of the broadcasted place.
Then the problem will be solved because arange won't have ties
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
