mbaret commented on issue #4919: [Relay][Pass] Don't consider constants as free vars in MergeComposite URL: https://github.com/apache/incubator-tvm/pull/4919#issuecomment-589757988 I think it actually implies a slightly different improvement should be made :) Currently no real checking happens in the ExtractPattern for constants, they are just always accepted as part of the pattern. Probably what should happen instead is that the pattern should fail to match if it's expecting a constant and instead sees a variable. Adding a quick unit test to make sure it doesn't incorrectly match a constant to a var and then implementing that check in ExtractPattern should be sufficient.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
