tqchen commented on issue #3934: [Runtime] MISRA-C compliant TVM runtime URL: https://github.com/apache/incubator-tvm/pull/3934#issuecomment-590670039 Thanks @liangfu for the great work, I did some quick comments. some generic comments: - Style issue, it would be great if we can have a consistent top-level style(e.g. TVMGraphRuntime) - API: is it possible to still expose the current TVM C runtime API? In this way most of the wrappers will still work and we will have one consitent way to call TVM functions. We can certainly provide a bit more wrapping on top
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
