comaniac commented on a change in pull request #4933: [Relay] Target annotation for external codegen URL: https://github.com/apache/incubator-tvm/pull/4933#discussion_r384019199
########## File path: src/relay/pass/annotate_target.cc ########## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * \file src/relay/pass/annotate_target.cc + * \brief Wraps a call with compiler_begin and compiler_end to indicate that + * the op of this call node will use external compiler. + */ + +#include <tvm/relay/attrs/annotation.h> +#include <tvm/relay/expr_functor.h> +#include <tvm/relay/op_attr_types.h> +#include <tvm/relay/transform.h> + +namespace tvm { +namespace relay { +namespace annotate_target { + +// A helper class to insert annotation boundaries for a program region that will +// be handled by a specific compiler. +class AnnotateTargetWrapper : public ExprMutator { + public: + explicit AnnotateTargetWrapper(const std::string& target) : target_(target) {} + + Expr VisitExpr_(const CallNode* cn) { + // TODO(@zhiics, @comaniac) Hanlde composite functions. + auto new_e = ExprMutator::VisitExpr_(cn); + + Call call = Downcast<Call>(new_e); + static auto fannotate = Op::GetAttr<FTVMAnnotateTarget>("target." + target_); + Op op = Downcast<Op>(call->op); + CHECK(op.defined()); + + if (fannotate.count(op)) { + bool external = fannotate[op](call->attrs, call->args); + if (external) { + tvm::Array<tvm::relay::Expr> compiler_begins; + for (const auto& it : call->args) { + const auto* begin_op = + runtime::Registry::Get("relay.op.annotation._make.compiler_begin"); + CHECK(begin_op); + Expr begin = (*begin_op)(it, target_); + compiler_begins.push_back(begin); + } + Expr update_call = CallNode::make(call->op, compiler_begins, call->attrs); Review comment: We could debate if we will put the subgraph fusion approach (or greedy approach) to this pass or a separate pass. Even we have decided to put it to this pass in the future, it's not hard to change this logic accordingly. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
