comaniac commented on issue #4939: [Relay][Pass] Sort MergeComposite generated function params alphabetically URL: https://github.com/apache/incubator-tvm/pull/4939#issuecomment-591017348 In my opinion, we should try to simplify the task of Relay passes. If we let the merge composite pass deal with all such issues without changing any Relay frontend, this pass would be hard to maintain and unreliable. If complexity is a concern, I would suggest adding an optional flag such as `sorted=False` to `FreeVars`. cc @zhiics
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
