anijain2305 commented on a change in pull request #4949: Conv3D ONNX supprot
and conv3D_ncdhw x86 schedules
URL: https://github.com/apache/incubator-tvm/pull/4949#discussion_r384806231
##########
File path: python/tvm/relay/frontend/onnx.py
##########
@@ -99,8 +99,10 @@ def _impl(attr):
return prefix + '1d' + surfix
if len(kernel) == 2:
return prefix + '2d' + surfix
- msg = 'Only 1D and 2D kernels are supported for operator {}.'
- op_name = prefix + '1d/2d'
+ if len(kernel) == 3:
+ return prefix + '3d' + surfix
Review comment:
Would suggest changing surfix -> suffix while you are on it :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
