soiferj opened a new pull request #4955: [Runtime] Fixed 
TVM_DLL_EXPORT_TYPED_FUNC to work on Windows
URL: https://github.com/apache/incubator-tvm/pull/4955
 
 
   On Windows, it is not valid to define a function in the same statement as 
declaring it `dllexport`. This change splits `TVM_DLL_EXPORT_PACKED_FUNC` into 
declaration and definition. Only declaration uses `TVM_DLL`.
   
   I have also verified that this change works on Linux.
   
   @zhiics @comaniac would you be able to take a quick look?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to