zhiics commented on a change in pull request #4927: [Relay][Pass] Add inline pass URL: https://github.com/apache/incubator-tvm/pull/4927#discussion_r385782213
########## File path: src/relay/pass/inline.cc ########## @@ -0,0 +1,227 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +/*! + * \file tvm/relay/pass/inline.cc + * \brief Global function inliner. It contains the following steps: + * + * - Preprocessing: eligibility checking. Only inline the functions that can + * be inlined. We currently only use simple rules to make the decision. No + * profitibility analysis is available for now. + * + * - Inline: replace the call with a function or the function body depending on + * the attribute of the callee function. For example, we return the function + * node when it doesn't use default compiler, i.e. llvm. This is because these + * functions are packed to be offloaded to external codegen. + * + * - Postprocessing: remove the replaced functions that have no reference. Review comment: No, dead code pass only works at function level. It doesn’t have global info ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
