jmorrill commented on a change in pull request #4970: Added CopyFromBytes and 
CopyToBytes convenience methods to NDArray.  Fixed typos.
URL: https://github.com/apache/incubator-tvm/pull/4970#discussion_r385947900
 
 

 ##########
 File path: include/tvm/runtime/ndarray.h
 ##########
 @@ -306,6 +324,26 @@ inline void NDArray::CopyFrom(const NDArray& other) {
   CopyFromTo(&(other.get_mutable()->dl_tensor), &(get_mutable()->dl_tensor));
 }
 
+inline void NDArray::CopyFromBytes(const void* data, size_t nbytes) {
 
 Review comment:
   Ok moved CopyTo/FromBytes to ndarray.cc

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to