FrozenGene commented on issue #4990: [Relay][Topi] BatchNorm support with 
run-time mean and variance calculation
URL: https://github.com/apache/incubator-tvm/pull/4990#issuecomment-595107872
 
 
   I think we needn't add `_empty_for_training_mode_inference`. If we find 
`mean` / `variance` is `VarNode`, we should call `Mean` and `Variance`.
   
   I don't think we should add `is_training` flag to relay `BatchNorm`. This 
should be done by users to make sure TF's model `BatchNorm`'s `is_training` 
flag be false. However, we still have user cases like you mention, so we could 
support as current implementation and don't add attribute to `BatchNorm`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to