LiangHao151941 commented on issue #4828: [QNN][TFLite] TFLite rounding mode 
support
URL: https://github.com/apache/incubator-tvm/pull/4828#issuecomment-595191104
 
 
   The problem is located and solved. The discrepancy comes from average 
pooling calculation when input is integral type. tflite does a UPWARD rounding 
after the division in avg_pool but current topi implementation of avg_pool does 
of FLOOR after the division.
   
   The fix is added and tested locally on cpu. Now the qnn tests in tflite 
test_forward has rtol and atol set to 0, which should meet the bit-exact 
exectution requirement. 
   
   @FrozenGene @anijain2305 @tqchen @u99127 Please have another look, thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to