FrozenGene commented on issue #4828: [QNN][TFLite] TFLite rounding mode support
URL: https://github.com/apache/incubator-tvm/pull/4828#issuecomment-595214366
 
 
   > Maybe we can mark these as todos due to lack of testcases for now, as make 
it for the next pr?
   
   We could mark it #TODO in tflite.py to remind us. Personally I wish we could 
handle it in a short time so that we don't forget it :-)
   
   > A new problem is that changing the default pooling behavior fails some 
pool op tests. I'm going to add an tflite_mode bool flag for 
relay.nn.avg_pool2d, how do you think? @FrozenGene 
   
   Yes. I think we have to do it. But we should keep the default value as our 
previous implementation.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to