FrozenGene commented on a change in pull request #4847: Return empty
CSourceModule when no lowered_funcs exists in Relay mod
URL: https://github.com/apache/incubator-tvm/pull/4847#discussion_r390724783
##########
File path: src/target/llvm/llvm_module.cc
##########
@@ -356,6 +356,26 @@ TVM_REGISTER_GLOBAL("codegen.build_llvm")
*rv = runtime::Module(n);
});
+TVM_REGISTER_GLOBAL("codegen.LLVMModuleCreate")
+.set_body([](TVMArgs args, TVMRetValue *rv) {
+ auto n = make_object<LLVMModuleNode>();
+ auto target = args[0].operator std::string();
+ auto module_name = args[1].operator std::string();
+
+ // create a default data layout
Review comment:
Sorry for later response. Minor comment: The logic here doesn't only create
default data layout but also create default target triple. We should update the
comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
