anijain2305 commented on a change in pull request #5036: [QNN] Support 4D
padding.
URL: https://github.com/apache/incubator-tvm/pull/5036#discussion_r390742934
##########
File path: python/tvm/relay/qnn/op/qnn.py
##########
@@ -280,6 +281,9 @@ def conv2d(data,
The computed result.
"""
+ # TODO enforce 4-way padding in topi/nn/conv2d after #4644 merged
+ # convert 2-way padding to 4-way padding
Review comment:
This is to make Relay Conv2d and QNN conv2d handle 4D padding in same
manner. Relay Conv2d looks like this
https://github.com/apache/incubator-tvm/blob/master/python/tvm/relay/op/nn/nn.py#L204-L206
I guess QNN changes got missed earlier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
