lfengad commented on issue #5042: [TF][Relay] TensorFlow Frontend support with 
shared params
URL: https://github.com/apache/incubator-tvm/pull/5042#issuecomment-598510426
 
 
   > yes, this is an issue I too see recently while working on TF 2.0 upgrade. 
Few suggestions on this.
   > 
   > * I think we can just remove the pop of used param and leave it assuming 
relay build process removes unused params automatically. cc @tqchen or @jroesch 
to confirm this behaviour.
   > * You may move the test case to default test_forward.py instead of a new 
file for it.
   
   Thank you for the suggestions! I can try it then!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to